Review of "Brightness utilities" version 7

Details Page Preview

Utilities for controlling brightness of external displays and controlling nightlight temperature

Extension Homepage
https://github.com/slaclau/brightness-utils-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in global scope (line 3 services/shell.js). 2. No reason to attach the timeout ids to extension object (line 503 quicksettings/BrightnessSliders.js). You can store it in a global scope variable and clean that up in the same module. Just call that in disable. That can help you to avoid using `Extension.lookupByUUID()`.