Review of "Bubblemail" version 21

Details Page Preview

Indicator for new and unread mail (Yahoo, Gmail, Microsoft, Outlook, Aol, Icloud, Protonmail, Gmx...) * Multiple accounts support * Local mail support for Maildir and Mbox formats * Remote mail support for Pop3, Imap and Exchange protocols * Automatic imports of Gnome Online Accounts * Plugin support with default ones : spam filter, sound alert, libnotify, user script * Avatars provided by the server or default colorized ones * Reports for connection errors. BE AWARE THAT THIS EXTENSION REQUIRES BUBBLEMAIL SERVICE INSTALLATION Check your distribution packaging system for availability. Packages for distributions and source tarballs can be found here : http://bubblemail.free.fr Please report any issue on the gitlab pages of the project : https://framagit.org/razer/bubblemail/issues https://framagit.org/razer/bubblemail-gnome-shell/issues

Extension Homepage
http://bubblemail.free.fr

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instances in the class and leave it there after prefs window close (line 33 prefs.js). Make it local to `fillPreferencesWindow()` and attach it to `window` to avoid garbage collecting before window close: ```js window._settings = this.getSettings() ``` 2. You cannot import `Gtk` to GNOME Shell process (line 25 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 3. Use `console.*` instead of `log()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 4. Also null out on disable: ```js this.mail_map = []; this.core_config = []; this.account_map = []; this.status_map = []; this.mail_app = null; ``` 5. Move line 87-88 (extension.js) to enable and null them out in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 6. Remove `getPreferencesWidget()` and `constructor()` from prefs.js. Not needed.
Razer posted a review
Thanks for your help, instructions have followed wisely but i suppose having used the wrong way for the last commit since it's now labeled 22
JustPerfection posted a review
`version` is auto increment and it's ego internal. If you want to use your own version, use `version-name`. It's a new key and we will update the docs for that soon.