Review of "Desktop Scroller (Original)" version 2

Details Page Preview

Switch between desktops scrolling right edge of the screen

Extension Homepage
https://bitbucket.org/mdiaz/desktop-scroller-original

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

gcampax posted a review
1) this in main() is never set, therefore it refers to the global object (window). Use "new main()" instead. 2) You can avoid using "self" if you bind your functions. 3) Hiding the actor is not enough, you need to destroy it completely. 4) You're not asking for struts, so you're eating events from underlying windows. 5) .actor is a very general style class, and is likely to conflict with built-in theming.