Review of "Desktop Scroller (Original)" version 3

Details Page Preview

Switch between desktops scrolling right edge of the screen

Extension Homepage
https://bitbucket.org/mdiaz/desktop-scroller-original

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

gcampax posted a review
bind() is already available as f.bind(obj) or Lang.bind(obj, f) (that's why I suggested it in the first place) In any case, you have a bigger problem: you're creating your primary actor inside init(). This is not allowed: init() is just for initialization code, and any serious work should be done in enable(). To help with that, you can return an object from init(), and implement enable() and disable() on that.