GNOME Shell Extensions

Review of "Gnome HDate" version 26

Details Page Preview

Gnome HDate

by hatul

Show Hebrew Date in the Panel. Requires libhdate-glib

Extension Homepage
https://github.com/amiad/gnome-hdate
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Rejected
23 Active
22 Rejected
21 Rejected
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Inactive
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary files: - stylesheet.css - po/he.po - po/gnome-hdate.pot 2. Wrong `shell-version`s: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#shell-version 3. Use `console.*` instead of `log()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 4. Don't use imports (line 9 and 16 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules 5. Move the `enable()` and `disable()` functions inside the default class you are exporting. 6. Remove try catch block (line 229 extension.js). We want the extension system catch the error. 7. Please remove the `constructor` (line 224 and 250 extension.js). 8. Please remove unnecessary comments in extension.js.