GNOME Shell Extensions

Review of "Gnome HDate" version 34

Details Page Preview

Gnome HDate

by hatul

Show Hebrew Date in the Panel

Extension Homepage
https://github.com/amiad/gnome-hdate
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
36 Active
35 Active
34 Rejected
33 Rejected
32 Active
31 Rejected
30 Active
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Rejected
23 Active
22 Rejected
21 Rejected
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Inactive
3 Active
2 Active
1 Active

Previous Reviews on this Version

fmuellner rejected
It looks like the prefs.js file was removed accidentally? Rejecting because there is now a non-functional "Settings" item. On a side note, the standard Temporal.PlainDate (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Temporal/PlainDate/year) has support for the Hebrew calendar. I don't know if it's suitable for the purpose, or whether support in mozjs/gjs dates back all the way to GNOME 45, but may it is interesting to you.