Review "Crypto Price Tracker" version 43

Review of "Crypto Price Tracker" version 43

Details Page Preview

Crypto Price Tracker

Simple extension to track price of Crypto Currencies Like: BTC, ETH, BNB, DOGE and etc.. Sources: Binance, Crypto, Coingecko, OKX Add coins by symbols, for example: * Binance pairs: "BTC/USDT" * OKX pairs: "LTC/USDT" * Coingecko pairs: "BTC/USD" Using api.coingecko.com, okx.com, binance.com, crypto.com Complete list of pairs: https://www.binance.com/indexSpa.html Complete guide: https://github.com/alipirpiran/Crypto-Price-Tracker-for-Gnome-Shell#readme ** if it faced error after update: **Restart Gnome-shell. (ALT+F2, r, Enter)

Extension Homepage: https://github.com/alipirpiran/Crypto-Price-Tracker-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
49	Active
48	Active
47	Active
46	Active
45	Active
44	Rejected
43	Rejected
42	Rejected
41	Active
40	Active
39	Rejected
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Rejected
29	Active
28	Active
27	Active
26	Rejected
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Rejected
18	Rejected
17	Active
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Rejected
7	Rejected
6	Active
5	Rejected
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

JustPerfection rejected November 20, 2023

1. Don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class. 2. `lookupByURL()` is a bad practice (line 2 `utils/cryptoUtil.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 3. You cannot create instance of objects in the constructor. You should clean them up on disable or don't make them global: - line 2 `utils/cryptoUtil.js` - line 29-32 `extension.js` - line 4 `settings.js` - line 4 `api/request.js` - line 8 `utils/cryptoUtil.js` [EGO Review Guidelines: destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Where `coingecko.json` file content is getting used? 5. Unused imports (line 1-2 `models/addCoinMenuItem.js`).