Review of "Crypto Price Tracker" version 52

Details Page Preview

Simple extension to track price of Crypto Currencies Like: BTC, ETH, BNB, DOGE and etc.. Sources: Binance, Crypto, Coingecko, OKX Add coins by symbols, for example: * Binance pairs: "BTC/USDT" * OKX pairs: "LTC/USDT" * Coingecko pairs: "BTC/USD" Using api.coingecko.com, okx.com, binance.com, crypto.com Complete list of pairs: https://www.binance.com/indexSpa.html Complete guide: https://github.com/alipirpiran/Crypto-Price-Tracker-for-Gnome-Shell#readme ** if it faced error after update: **Restart Gnome-shell. (ALT+F2, r, Enter)

Extension Homepage
https://github.com/alipirpiran/Crypto-Price-Tracker-for-Gnome-Shell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • settings.js:5
    Extension.lookupByUUID('crypto@alipirpiran.github')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Version Status
52 Rejected
51 Active
50 Active
49 Active
48 Active
47 Active
46 Active
45 Active
44 Rejected
43 Rejected
42 Rejected
41 Active
40 Active
39 Rejected
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Rejected
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Rejected
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. 2. `this._destroyed` is a bad practice: [Extension Best Practices Guidelines: Lifecycle and Destruction State](https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state)