GNOME Shell Extensions

Review of "Translate Indicator" version 4

Details Page Preview

Translate Indicator

by sevenus

Translate extension for Gnome-Shell - based on translate-shell, inspired by Tudmotu's clipboard-indicator and gufoe's text-translator

Extension Homepage
https://github.com/sevenuz/gnome-translate-indicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Rejected
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Unnecessary import (line 1 `prefs.js`). 2. Move it to enable and null that out in disable (line 19 `extension.js`) [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Timeout should be removed on destroy/disable (line 201 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. Unnecessary comments (line 113-115 `extension.js`).
sevenus posted a review
I submitted a new version fixing your points. Would be nice if you review it :)