Review of "Icon Hider Updated" version 2

Details Page Preview

Show & Hide icons from the top panel


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Rejected
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please long and schema id in gettext domain. 2. You cannot create instance of objects in the constructor (line 6-8 `extension.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) Move those lines to enable and null it out in disable. 3. Simply return the instance and don't hold it in global scope (line 167 `extension.js`). 4. Too much for init (line 168 `extension.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) Move everything from `_init()` to enable and null them out in disable. 5. Timeout should be removed on disable (line 123 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) Anyway, I recommend to remove the timeout and simply enable the extension without timeout. 6. Also null out in disable: ```js this.hiddenIcons = null; this.knownIcons = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions