Review of "Icon Hider Updated" version 4

Details Page Preview

Show & Hide icons from the top panel


No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
10 Rejected
9 Active
8 Inactive
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

lx358hcl posted a review
Hey, thanks for reviewing. I've implemented all the fixes you (JustPerfection) told me to. The only thing I didn't change was removing timeout on the enable()-function. This is because if I remove the timeout that will cause the PopShell in !Pop_OS to constantly show up in the TrayArea/StatusArea on every boot/login/logout regardless of the settings for the extension. So I kept that. I am however cleaning it up upon disabling which I didn't do earlier. Hope that is ok? Thanks
JustPerfection rejected
1. Please use a shorter gettext domain. 2. You cannot create instance of objects in global scope (line 6-8 `extension.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) To fix that, move those lines to enable and null that out in disable. 3. Please remove line 10 `extension.js` since it is not used. 4. Timeout should be removed on disable (line 124 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) By remove I mean you should assign the timeout source id when creating timeout and removing the timeout source id in disable. So, simply replacing this for line 124 can fix the issue: ```js this.timeout = setTimeout(() => { ```