Review of "Custom Reboot" version 8

Details Page Preview

Reboot into another OS directly from GNOME. A expansion of https://github.com/docquantum/gnome-shell-extension-customreboot

Extension Homepage
https://github.com/Nova1545/gnome-shell-extension-customreboot

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. `lookupByUUID()` is a bad practice (line 23 `bootloader.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 2. Please also null out `this.menu` in disable. [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Unused imports: - line 8-10 `extension.js` - line 6-7 `prefs.js`