Review of "Weeks Start on Monday Again..." version 15

Details Page Preview

... or maybe not, and that's why the start day is configurable in the preferences. This is an updated version of the "Weeks Start on Monday" extension for newer Gnome Shells.

Extension Homepage
https://github.com/F-i-f/weeks-start-on-monday

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Inactive
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

F-i-f posted a review
Note that I have two versions of this extension currently under review, and I need them BOTH APPROVED. - 14 (other version), for GS 44 compatibility. - 15 (this version), for GS 45 compatibility. Thanks!
JustPerfection rejected
Please don't store anything in the properties of the default class you are exporting (`prefs.js`), if you don't want to clean them up on window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) To solve that, make them local to `fillPreferencesWindow()`. Also attach settings to `window` to avoid garbage collecting before window close: [Extension Guide: preferences](https://gjs.guide/extensions/development/preferences.html#prefs-js)