Review of "Customised Workspaces" version 61

Details Page Preview

Customised Workspaces enables creating isolated and customised workspaces. * Choose a different background image for each workspace * Your dash will have unique favourite applications on each workspace * Optionally isolate running applications to only appear on the dash in their respective workspace * Optionally show workspace information and actions in the overview * Set each customised workspace to autoload on specific workspaces * Hide the extension once you've configured your preferences to enjoy seamlessly upgraded workspaces in gnome shell Please do not leave a comment for issues and instead report it here: https://github.com/blipk/Customised-Workspaces/issues

Extension Homepage
https://github.com/blipk/Customised-Workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. `lookupByUUID()` is a bad practice (line 52 `extension.js`). You already set `this` in the entry point. Just need to set `WorksetsInstance` to null (line 104 `extension.js`) 2. Don't set that to global. You can set that to `WorksetsInstance` (line 62 `extension.js`). 3. Make it local to `fillPreferencesWindow` (line 35 `prefs.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) and don't make the same instance twice (line 35-36 `prefs.js`) 4. `getSettings()` in the entry point should only be used for your own extension settings: - line 75, 84 `extension.js` - line 110, 122, 357, 364 `sessionManager.js` 5. Don't use `var`. Use `let` and `const` instead. 6. Don't use eval (line 231, 232, 239, 375 `utils.js`). We have `injectionManager` in 45: [Extension Guides: InjectionManager](https://gjs.guide/extensions/topics/extension.html#injectionmanager) 7. Extensions cannot use `run_dispose()` (line 122 `extension.js`): > This function should only be called from object system implementations. [gjs-docs: run_dispose](https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose)
k-extd posted a review
Most of these things where being done in previous versions of the extension. Why do you only bring them up now ?? I don't even use this extension anymore but I've put in SO MUCH EFFORT to get this working again for community members who keep asking. I can fix most of them but I'm not fixing 6, it's too much time to go through and rewrite. If all these things are ABSOLUTELY NOT ALLOWED THEN YOU SHOULD WRITE THAT DOWN SOMEWHERE AND REMAIN CONSISTENT SEEING AS THEY HAVE BEEN IN PREVIOUS EXTENSION VERSIONS THAT YOU HAVE REVIEWED. However I think at least a few of these are just your personal preferences, PEOPLE HAVE LIVES YOU KNOW, YOU DONT HAVE TO SLOW THEM DOWN BY IMPOSING YOUR PERSONAL PREFERENCES ON THEIR WORK
k-extd posted a review
also 4 is just declaring a function that uses getSettings its not actually calling getSettings My extension bases its functionality off those other extensions so I need to know what there settings are
JustPerfection posted a review
I'm reviewing all lines instead of diff for 45 extensions since the review guidelines has been updated.