Review of "ESP (Extensions Search Provider)" version 46.6 (15)

Details Page Preview

Search and access settings of installed extensions from the Activities overview

Extension Homepage
https://github.com/G-dH/extensions-search-provider

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
47.2 (24) Active
44.7 (23) Active
44.7 (22) Active
47.2 (21) Active
47.1 (20) Inactive
47.0 (19) Inactive
44.6 (18) Active
46.6 (17) Inactive
44.6 (16) Rejected
46.6 (15) Rejected
44.5 (14) Inactive
46.5 (13) Inactive
44.4 (12) Inactive
46.4 (11) Inactive
44.3 (10) Inactive
46.3 (9) Inactive
46.2 (8) Rejected
44.2 (7) Inactive
44.2 (6) Inactive
46.2 (5) Inactive
44.1 (4) Inactive
46.1 (3) Inactive
46.1 (2) Inactive
46.1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
While the extension system modification is opt-in, modifying the extension system is too much here since other extensions getting managed by your extension. Also, as mentioned on Matrix channel, you are changing the async to sync here which can lead to concurrency issues. [EGO Review Guidelines: Avoid interfering with the Extension System](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#avoid-interfering-with-the-extension-system)