Review of "Touchpad Indicator" version 4

Details Page Preview

Automatically disable other pointing devices when an external mouse is plugged in.

Extension Homepage
https://github.com/askmrsinh/touchpad-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
37 Active
36 Active
35 Active
34 Inactive
33 Active
32 Rejected
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Rejected
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

gcampax posted a review
Sorry, you cannot use Gettext.textdomain, as that overrides the value used by core shell. Use the bound version of gettext ("imports.gettext.domain('yourdomain')") instead. Also, apparently you're not destroying the touchpad settings object or disconnecting from its signals, which means that your callback may be called after disable().
orangeshirt posted a review
Thanks for your review. A remark to the Gettext thing. I orientate myself on the description at http://live.gnome.org/GnomeShell/Extensions/FAQ/CreatingExtensions I think the first lines there should be changed.