Review "Screen Rotate" version 16 - GNOME Shell Extensions

Review of "Screen Rotate" version 16

Details Page Preview

Screen Rotate

by shyzus

Enable screen rotation regardless of touch mode. Fork of Screen Autorotate by Kosmospredanie.

Extension Homepage: https://github.com/shyzus/gnome-shell-extension-screen-autorotate

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
27	Active
26	Active
25	Active
24	Active
23	Active
22	Inactive
21	Rejected
20	Active
19	Active
18	Active
17	Rejected
16	Rejected
15	Active
14	Active
13	Active
12	Inactive
11	Rejected
10	Inactive
9	Inactive
8	Inactive
7	Inactive
6	Rejected
5	Rejected
4	Inactive
3	Rejected
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected March 22, 2024

1. Timeout should be removed on disable (line 333 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. I recommend to pass `this` from the entry point instead of using `lookupByUUID()` (line 66 `extension.js`).