Review of "Quick Lofi" version 1

Details Page Preview

Relax to lo-fi tunes with just a click. You need MPV and socat for this extension to work. Fedora: sudo dnf install mpv socat Ubuntu: sudo apt install mpv socat Arch Linux: sudo pacman -S mpv socat

Extension Homepage
https://github.com/eucaue/gnome-shell-extension-quick-lofi

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the version from the import (line 2 `prefs.js`). 2. Why gtk2? 45 uses gtk4 and adw. 3. Use new line between functions and classes. 4. Don't store `_settings` and `_radios` as properties in `prefs.js` since they won't get garbage collected after window close. you can clean them up on window close request signal: ```js window.connect('close-request', () => { // cleanup here }); ``` 5. I know this is a transpiled version but please config the typescript so we can review it easier. For example line 1-13 `extension.js` can be dropped. 6. `lookupByURL()` is a bad practice (line 30 `extension.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 7. I recommend to don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class. 8. Also null out `this._indicator` in disable. 9. After removing the session modes from the metadata, please remove line 231-232 `extension.js`. Your extension is not legible for session mode since it is calling spawn command and that should be happening in unlock dialog: [EGO Review Guidelines: Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes) 10. Add to the description that this extension is using mpv as its dependency. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions