Review of "Quick Lofi" version 8

Details Page Preview

Relax to lo-fi tunes with just a click. You need MPV and socat for this extension to work. Fedora: sudo dnf install mpv socat Ubuntu: sudo apt install mpv socat Arch Linux: sudo pacman -S mpv socat

Extension Homepage
https://github.com/eucaue/gnome-shell-extension-quick-lofi

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `icons/icon-paused-symbolic (Copy).svg`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please remove the timeout in the same class (line 124 `extension.js`) not in line 306. You can create `Player.destroy()` and do it in there. Also no need to use `dispose()` instead of `destroy()` in line 301. You can still use `destroy()` and then do this at the end of `destroy()` function: ```js super.destroy(): ```