Review of "Allow Locked Remote Desktop" version 12

Details Page Preview

Allow remote desktop connections when the screen is locked NOTE: For at least some people, with GNOME 47 this extension is causing login sessions to crash when accessed remotely, even when the extension isn't enabled and even when the screen wasn't locked before connecting to the session. If you are running into this problem you will need to uninstall the extension until it is resolved. See https://github.com/jikamens/allow-locked-remote-desktop/issues/13 and https://gitlab.gnome.org/GNOME/mutter/-/issues/3839 for additional info. If your GNOME system is running systemd and you are able to log into it via SSH, then you can achieve the same functionality of this extension by logging into the system before you RDP in and using "loginctl" to unlock your screen. For example, I use this as the startup command for the SSH tunnel I have configured into Remmina for remoting into my system: loginctl unlock-session $(loginctl list-sessions | awk '/seat/ {print $1}')

Extension Homepage
https://github.com/jikamens/allow-locked-remote-desktop/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Active
8 Inactive
7 Inactive
6 Active
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active
Please remove line 28-29 and 43-44 for the next version. Also remove the logs. or use `console.debug()`.
Jonathan Kamens posted a review
I don't agree with either of your requested changes. Comments explaining why added at https://github.com/jikamens/allow-locked-remote-desktop/commit/e755b8d90432eda8db840fd09ad46ef4b8133bd5
JustPerfection posted a review
For comments: I don't mean you shouldn't log. I mean you shouldn't use `log()` **function** and use `console.*` instead. Please read the docs for that: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)
Jonathan Kamens posted a review
Ah, understood, thanks. Will fix. I actually fixed this in a previous release but then the fix reverted because I forgot to push it from the machine where I made the fix back into github and then subsequently did a new release from a different machine. :-/ I've taken steps to prevent this from happening again.
JustPerfection posted a review
No problem.