Review of "Docker" version 32

Details Page Preview

Quick access to Docker and Docker Compose.

Extension Homepage
https://gitlab.com/stickman_0x00/gnome_shell_extension_docker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. No need to use `this.initTranslation()` (line 13 `extension.js`, line 11 `prefs.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. Please don't store any instance of objects in a property in the default class you are exporting (line 16 `prefs.js`) since that won't allow the garbage collector do it's job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { this._settings = null; }); ```
stickman_0x00 posted a review
Thanks!