Review of "moveclock" version 1

Details Page Preview

Move the clock to right side of the panel

Extension Homepage
https://github.com/kuvaus/moveclock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use a less generic name for the default class you are exporting (line 11 `prefs.js`). 2. Why this extension needs schemas for enable or disable the extension? That should be managed by the extension system, not your extension. Maybe remove prefs since that's not needed. 3. Remove all try and catch blocks in `extension.js` since they won't allow the extension system catch the error. 4. Please remove unnecessary import (line 5 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
kuvaus posted a review
Hi, Thanks a lot for looking through the code so thoroughly! I submitted a new version with some changes. 1) Good point. Class is now renamed to moveclock_preferences. 2) Ah that was remnant of old code (I had tried to make a button to enable/disable the extension). Removed the schemas. Removed also the 'Configure the extension settings' group from the prefs.js. 3) This was great. Removing the try blocks revealed that 'statusMenu' was causing undefined error because the menu is called 'quickSettings'. After fixing this, the extension should now work properly without errors. Thanks! 4) Done.