Review of "Rounded Window Corners Reborn" version 1

Details Page Preview

Add rounded corners to all windows. Fork of the now unmaintained Rounded Window Corners extension.

Extension Homepage
https://github.com/flexagoon/rounded-window-corners

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Better to start the interface name with `org.gnome.Shell.Extensions.` (line 2 `dbus/iface.xml`)? Anyway, that's not included the bus name from the `dbus/client.js`. 2. Please use new lines between functions and classes. 3. Timeout should be removed on destroy: - line 57 `manager/shadow_manager.js` - line 103 `manager/rounded_corners_manager.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. You cannot have the same schema path and id as the original. 5. No need to use `this.initTranslation()` (line 13-14 `prefs.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 6. You need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 7. You should `uninit_settings()` in disable. 8. Please disconnect the signal on disable (line 46 `extension.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 9. `this._window_actor_tracker()` should be called on disable. 10. Please also add reborn to the default class you are exporting. 11. You shouldn't use old imports in 46 (line 13 `prefs.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions