Review of "Rounded Window Corners Reborn" version 5

Details Page Preview

Add rounded corners to all windows. Fork of the now unmaintained Rounded Window Corners extension.

Extension Homepage
https://github.com/flexagoon/rounded-window-corners

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please disconnect on disable (line 42, 102 `extension.js`): [Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 2. Line 103-105 `extension.js` should be happening on disable not on `this.connect('destroy',...`. 3. The `preferences/window_picker/` folder is running inside the shell process. I recommend to don't hold those modules in the `preferences` folder since that can misleading the reviewers.