Review of "fw-fanctrl" version 2

Details Page Preview

Fan Control for Framework. This extension is not affiliated, funded, or in any way associated with Framework Computer.

Extension Homepage
https://github.com/joax/fw-fanctrl-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

joaxap posted a review
Re-arranged memory use. This one is resilient to sleep/resume. Tested on more scenarios: * suspend * hibernate * logout * lock screen * disable fw-fanctrl executable
JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with Framework Computer. 3. Please use a less generic name for the default class you are exporting (for stack trace). 4. Don't use sync spawn since that can freeze the shell process (line 132 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions