Create rules to open specific websites in specific web browsers for links clicked in any application on your computer. (emails, chat etc)
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
Version | Status |
---|---|
17 | Active |
16 | Inactive |
15 | Rejected |
14 | Rejected |
13 | Active |
12 | Active |
11 | Rejected |
10 | Active |
9 | Active |
8 | Inactive |
7 | Inactive |
6 | Rejected |
5 | Inactive |
4 | Rejected |
3 | Inactive |
2 | Rejected |
1 | Inactive |
Since this a 45 port (ESM), I reviewed all lines (not just the diff): 1. Bad xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Don't need to do line 52-87 `utils.js`. That's not needed and also you are breaking these rules by doing that: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Also empty the `messages` on disable (line 96 `uiUtils.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class or simply export the function. 5. Extensions cannot use `run_dispose()` (line 77 `extension.js`): [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 6. Please remove Line 63 and 78 from `extension.js`. 7. `_installbowser()` (line 93-117 `extension.js`) is too much for extensions. We are generally against spawn command but installing those files seems too much on **each enable**. `enable()` can get called so many times (for example, on unlock). I understand you want to run the app later but instead of installing why not having `app` folder in the extension folder and use that directly? 8. What Python script line 432 `extension.js` exactly calling? Shipping Python scripts in the extension package is pretty discouraging but here we *cannot see the script* since they packed in gresources and that can make it pretty much vague to review.