Review of "GameMode Shell Extension" version 1

Details Page Preview

GameMode Status Indicator for GNOME Shell!

Extension Homepage
https://github.com/trsnaqe/gamemode-shell-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Active
9 Inactive
8 Inactive
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. While it is fast, it's better to use async spawn command since sync can freeze the shell process: [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 3. Please add GitHub or GitLab url to the metadata.json: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 4. This extension doesn't have any schemas xml file (line 157 `extension.js`). 5. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 6. Please don't use old `imports` in ESM (line 2 extension.js). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions