Review of "GameMode Shell Extension" version 19

Details Page Preview

GameMode Status Indicator for GNOME Shell!

Extension Homepage
https://github.com/trsnaqe/gamemode-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:133
          this._doNotDisturbToggle.connect("toggled", (item, value) => {
            this._settings.set_boolean("enable-do-not-disturb", value);
          })
  • extension.js:149
          this._iconVisibilityToggle.connect("toggled", (item, value) => {
            this._settings.set_boolean("show-icon-only-when-active", value);
          })
  • extension.js:122
          this._notificationCloseToggle.connect("toggled", (item, value) => {
            this._settings.set_boolean("show-close-notification", value);
          })
  • extension.js:113
          this._notificationLaunchToggle.connect("toggled", (item, value) => {
            this._settings.set_boolean("show-launch-notification", value);
          })

All Versions

Version Status
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Inactive
8 Inactive
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

Trsnaqe auto- rejected
Auto-rejected because of new version 20 was uploaded