Review of "Toggle Headphone" version 1

Details Page Preview

Toggles between 2 pre-defined audio sources, labeled as 'headphone' and 'speaker'.

Extension Homepage
https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary files: - `stylesheet.css` - `po/toggleAudio@blackeyeprojects.de.pot` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Also null out in disable: ```js this._mixerControlFacade = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. When you store instance of objects in the properties of the default class you are exporting, it won't let the garbage collector do its job (line 15-25 `prefs.js`). You have two options: 1. Make them local to the functions. 2. Null them out in the window close request: ```js window.connect('close-request', () => { this._settings = null; }); ``` 4. Move `lib/util/DebugHelper.js` to a `prefs` folder or find a solution to make it obvious for the reviewers to know that file is prefs only module. 5. Timeout should be removed on destroy (line 112, 144 `lib/MixerControlFacade.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
JustPerfection posted a review
About #3: You can also move everything (other than `fillPreferencesWindow()`) to another class and only create the instance of that class in `fillPreferencesWindow()`. That's the better solution.
Blackeye posted a review
Commit: Fix for Reviewpoint 1,2,4 https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/commit/613fa5ab260edc75c3489fb6b3aa3ea7b8a7da24 Commit: Fix for Reviewpoint 3 https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/commit/c0a6ccd349eb86b06c9992bb3ea6dcb4957df881 Commit: Fix for Reviewpoint 5 https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/commit/d3b9ce0edbf72f9f17b499eb3e6609c066457736 next version uploaded