Review of "Toggle Headphone" version 4

Details Page Preview

Toggles between 2 pre-defined audio sources, labeled as 'headphone' and 'speaker'.

Extension Homepage
https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

Blackeye posted a review
PR is here: https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/pull/4 hotkey functionality: https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/pull/4/commits/fe96f62f999792048fd361c3b8e7cf5ff845784a preferences: https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/pull/4/commits/73151f6a5cb6fe9342eef07176af1f8b59a74e2e use hotkeys only if enabled in settings: https://github.com/Blackstareye/toggleAudio-blackeyeprojects.de/pull/4/commits/b9215bde1bba686d739f4315c2120a6378285cf9 hope this helps :)
JustPerfection active
It's better to change line 176 `extension.js` to `destroy()` instead. It will be like this: ```js destroy() { this._keybinder.destroy(); this._keybinder = null; super.destroy(); } ```
Blackeye posted a review
Ahh okay, I was unsure if the overwrite will work with all the gobject binding stuff. I will fix this and upload it again. Thanks! :)