Review of "VSCode Workspaces" version 6

Details Page Preview

A VSCode/Codium Workspace management tool-set for GNOME - This extension is not affiliated, funded, or in any way associated with Microsoft and vscode software.

Extension Homepage
https://github.com/ZanzyTHEbar/vscode-workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
16 Active
15 Rejected
14 Rejected
13 Active
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Inactive
7 Inactive
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with Microsoft and vscode software. 2. Please don't store any instance of objects in a property in the default class you are exporting (line 8 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to move them to another class or make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 3. Wrong class name (line 5 `prefs.js`). 4. Also null out in disable: ```js this._recentWorkspaces = null; this._workspaces = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions