Review of "VSCode Workspaces" version 7

Details Page Preview

A VSCode/Codium Workspace management tool-set for GNOME - This extension is not affiliated, funded, or in any way associated with Microsoft and vscode software.

Extension Homepage
https://github.com/ZanzyTHEbar/vscode-workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
16 Active
15 Rejected
14 Rejected
13 Active
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Inactive
7 Inactive
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Please remove line 63-65 `prefs.js`. Not needed. You can attach the settings to the `window` in to avoid garbage collecting before window close. So, instead of line 7 (`prefs.js`) you can do: ```js window._settings = this.getSettings(); const _settings = window._settings; ```
ZanzyTHEbar posted a review
That does not work in typescript and breaks my builds.
ZanzyTHEbar posted a review
I just extended the PreferencesWindow interface - hopefully thats fine.
JustPerfection posted a review
What's the error? You can also use `window._settings` directly instead of creating another `_settings` as const. Just like the [prefs example](https://gjs.guide/extensions/development/preferences.html#prefs-js).
ZanzyTHEbar posted a review
There is no `_settings` object on the Awd.PreferencesWindow object, according to my intellisense and the files i have for the Awd library. I had to extend the interface to include it in order to pass the ts build steps. But, it all builds now, and works fine (on my test machines) - so should be good :).