Review of "SoundCard Switch" version 5

Details Page Preview

Enable or disable the sound card entirely by adding or removing the sound device. Bluetooth headset not be affected.

Extension Homepage
https://github.com/xnow-me/soundcard-switch.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
1. Please add this to the `Indicator` class: ```js destroy() { if (sourceId) { GLib.Source.remove(sourceId); sourceId = null; } super.destroy(); } ``` and remove line 143-146 `extension.js`. Also, You can make `sourceId` a property of `Indicator` class instead of using a global variable. 2. Please remove line 150-156 `extension.js`. 3. `lookupByUUID()` is a bad practice (line 54 and 61 `extension.js`). You can send `this` from the entry point to the `Indicator` class (dependency injection). Wanna fix and send it again?
kongfang auto- rejected
Auto-rejected because of new version 6 was uploaded