Review of "SoundCard Switch" version 2

Details Page Preview

Enable or disable the sound card entirely by adding or removing the sound device. Bluetooth headset not be affected.

Extension Homepage
https://github.com/xnow-me/soundcard-switch.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy (line 74 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Use `console.*` instead of `log()` and `LogError()`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging 3. Add gettext domain to metadata.json: https://gjs.guide/extensions/overview/anatomy.html#optional-fields