Review of "SoundCard Switch" version 8

Details Page Preview

Enable or disable the sound card entirely by adding or removing the sound device. Bluetooth headset not be affected.

Extension Homepage
https://github.com/xnow-me/soundcard-switch.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
8 Rejected
7 Active
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't use sync spawn since that can freeze the shell process (line 65, 158 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 2. Not `this.sourceId` since you are removing `sourceId` in disable (line 122 `extension.js`). 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions