Review of "IM Panel integrated with OSK" version 1

Details Page Preview

IM Panel Integrated with OSK is a GNOME Shell extension that improves the operation of input methods on touch screens by adding several features to the GNOME OnScreen Keyboard. This extension is based on [input-method-panel](https://extensions.gnome.org/extension/261/kimpanel/).

Extension Homepage
https://github.com/hallelujahdrive/impanel-with-osk

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Is this a fork? If so, you need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Please don't use `getPreferencesWidget()` for the default class you are exporting in `prefs.js`. Use `fillPreferencesWindow()` instead: [Port Guide 42: fillPreferencesWindow](https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow) 4. Please use a less generic name for the default class you are exporting (line 1654 `extension.js`). 5. Move line 1659 `extension.js` to enable and null it out in disable: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 6. Timeout should be removed on destroy (line 712 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions