Review of "IM Panel integrated with OSK" version 8

Details Page Preview

IM Panel Integrated with OSK is a GNOME Shell extension that improves the operation of input methods on touch screens by adding several features to the GNOME OnScreen Keyboard. This extension is based on [input-method-panel](https://extensions.gnome.org/extension/261/kimpanel/).

Extension Homepage
https://github.com/hallelujahdrive/impanel-with-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:876
    		this.layout = new St.BoxLayout({
    			style_class: "popup-menu-content",
    			vertical: true
    		})
  • extension.js:883
    this.lookupTableLayout = new St.BoxLayout({ vertical: this.kimpanel.isLookupTableVertical() })
  • extension.js:882
    this.upperLayout = new St.BoxLayout()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:260
    		this.panGesture.connect("pan-update", (action) => {
    			const delta = action.get_delta();
    			const adjustment = this.get_vadjustment();
    			adjustment.value -= delta.get_y();
    		})

All Versions

Version Status
8 Unreviewed
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected