Review of "Port Forwarding Extension" version 3

Details Page Preview

Extension to enable port forwarding via SSH

Extension Homepage
https://github.com/SJBERTRAND/portforwarding-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
1. Please move line 269 to the `Indicator.destroy()` class. That way, the same class is responsible to cancel not another one. 2. There is no `this._cancellable` (line 258 `extension.js`). 3. I can approve it like that since it is coming from user's settings (line 135 `extension.js`) but it is preferred to prepare the password string since that can lead to security issues. Wanna fix and send it again?
SJBERTRAND auto- rejected
Auto-rejected because of new version 4 was uploaded