Review "Nepal Calendar" version 1 - GNOME Shell Extensions

Review of "Nepal Calendar" version 1

Details Page Preview

Nepal Calendar

by publishername

Shows Nepali date along with events and festivals.

Extension Homepage: https://github.com/PublisherName/nepali-calendar-gs-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
9	Active
8	Active
7	Rejected
6	Rejected
5	Rejected
4	Rejected
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected November 2, 2024

1. Move line 73 `extension.js` to 83. 2. Use different property name and also remove that before creating new one and in destroy (lien 86 `extension.js`). 3. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 4. `lookupByURL()` is a bad practice (line 4 `utils/NepaliDateConverter.js`). You can send `this.path` from the entry point to the function needing it. 5. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions