Review of "Nepal Calendar" version 4

Details Page Preview

Shows Nepali date along with events and festivals.

Extension Homepage
https://github.com/PublisherName/nepali-calendar-gs-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. In schemas file, id should be `org.gnome.shell.extensions.nepal-calendar` and path should be `/org/gnome/shell/extensions/nepal-calendar`. Please fix the schema filename after that. Also use `org.gnome.shell.extensions.nepal-calendar` in `metadata.json`. 2. Please don't store any instance of objects in a property in the default class you are exporting (line 11 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) To fix that, replace that line with: ```js window._settings = this.getSettings(); ``` and remove line 57 `prefs.js`. Don't forget to fix line 43 `prefs.js`.