Review of "Skype Contact Search" version 1

Details Page Preview

Allows Skype contacts to be searched from within the applications overview. Clicking on a contact will launch a chat window. After install Skype will also pop-up a window to confirm that the extension is allowed to communicate with the Skype API. Latest version has a bug, which I hope to fix in the next day or so, until then if you don't see any contacts, try reloading the shell (Alt F2, then 'r' in the box that pops up).


No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Jasper St. Pierre posted a review
Wow... that sure is an API. > let rg = RegExp( terms, "gi"); This will break for any terms that have "special characters". Just implement the standard matching algorithm used by all the other search providers. > let ret,stdout,stderr,which_apt_cache,which_apturl; Leftover junk from another extension?
paulstanyer posted a review
Hi, thanks for reviewing. Yes I had a little fun with what passes as the Skype API :) Have now added the extra filtering for user input, and removed the junk left from the other Search provider. I wanted to make sure I only escaped characters that were likely to break the regex. The appSearch filtering basically stripped anything that wasn't A-Za-z0-9, so I rolled my own regex to escape characters that would cause issues. Let me know ifg you think I have likely missed anything I should be checking for. I've also added a little nod to the author of appSearch, as building on the work they had already done saved me hours of trying to figure things out. Uploading now. Thanks again.