> // first escape user input Outdated comment? > terms = terms.toString(); This will convert terms to a comma-separated array. If a user enters "foo bar", it will search for "foo,bar". Not quite what users would expect. You're also losing case insensitivity here. I believe terms is already lower-case when you get them, but you still need to call toLowerCase on the contact's name as well. You might want to look at some search provider implementations (like the one I wrote long ago in "placesDisplay.js") to see how they handle individual terms. We want to AND terms, but they don't have to be in order, nor does each term have to be complete. So, if the contact's name is "Jonathan McCann" and the user enters "jon mccann", your search provider should still find it. Still, this is usable for now, and we're not supposed to reject on conditions of behavior, just code quality, so I'm going to accept it. Feel free to submit a version that fixes these problems, or not.

Hi, thanks, that makes sense - I didn't realise terms was an array, is there any documentation for a SearchProvider - I couldn't find anything so literally just working on what I can see in other code. I'll get a new version submitted today to sort those points above. I want to add a few more bits anyway - such as looking at status and displaying a different icon if the user is online/busy etc. cheers