Review of "Accent Icons" version 1.2 (7)

Details Page Preview

Makes icons follow system accent color and can be used with MoreWaita

Extension Homepage
https://github.com/taiwbi/gnome-accent-directories

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.2 (7) Rejected
1.1 (6) Active
1.1 (5) Active
1.1 (4) Rejected
1.0 (3) Active
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 24 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ```