Review of "Window List in Panel" version 11

Details Page Preview

Display workspaces thumbnails and window list in the top panel. This unofficial extension is a fork of the official Classic Mode's Window List GNOME extension. Indicators in panel's left box will be moved to right box. Needs a session restart.

Extension Homepage
https://github.com/fthx/window-list-in-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot import `Gtk` to the GNOME Shell process (line 15 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 2. Timeout should be removed on destroy (line 405 and 1337 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. `lookupByURL()` is a bad practice (line 501 `extension.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection). 4. Please change the schema id and path since that's the same as the original. 5. Better to disconnect the signals on disable: - line 102, 334, 593, 963 and 971, ... `extension.js` - line 51, 194 `workspaceIndicator.js` [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals)