Review of "Herkul" version 1

Details Page Preview

Prayer times based on Diyanet.gov.tr's schedule and Herkul Radio https://herkul.org/ streaming from Wohooo.net. Features include prayer time notifications, radio streaming, and multi-city support.

Extension Homepage
https://github.com/faymaz/herkul

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add to the description that this extension is using `diyanet.gov.tr` and `wohooo.net` services. 2. Remove `_getSettings()`. Use `this.getSettings()` instead. - line 18 `prefs.js` - line 604 `extension.js` 3. Remove line 15 `prefs.js`: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 4. Make `this._settings` local to `fillPreferencesWindow()`. 5. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 6. Remove `initTranslations()` (line 55 `extension.js`). 7. Timeout should be removed on destroy (line 193, 357, 482, 506 and 529 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 8. You cannot use old imports in 45+ (line 162 `extension.js`). 9. Remove `img` folder: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files)
JustPerfection posted a review
Btw, for #8 all of these lines need to be fixed: Line 12, 156, 162, 166, 498, 499, 504, 508, 581 `extension.js`.