Review of "Herkul" version 4

Details Page Preview

Prayer times based on Diyanet.gov.tr's schedule and Herkul Radio https://herkul.org/ streaming from Wohooo.net. Features include prayer time notifications, radio streaming, and multi-city support.

Extension Homepage
https://github.com/faymaz/herkul

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `po` folder and `Makefile`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please remove all the lines for initializing the translation. Just using `gettext-domain` in `metadata.json` is enough. 3. You can import gettext: [Port Guide 45: gettext](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) No need to use `imports` for it which is not allowed in >=40 extensions: [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules)