A Gnome extension helps you tracking gold price in realtime. Service provider: goldprice.org
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 33 | Active |
| 32 | Rejected |
| 31 | Rejected |
| 30 | Rejected |
| 29 | Rejected |
| 28 | Active |
| 27 | Active |
| 26 | Inactive |
| 25 | Inactive |
| 24 | Inactive |
| 23 | Inactive |
| 22 | Inactive |
| 21 | Inactive |
| 20 | Inactive |
| 19 | Inactive |
| 18 | Inactive |
| 17 | Rejected |
| 16 | Active |
| 15 | Inactive |
| 14 | Rejected |
| 13 | Inactive |
| 12 | Inactive |
| 11 | Inactive |
| 10 | Rejected |
| 9 | Active |
| 8 | Inactive |
| 7 | Rejected |
| 6 | Rejected |
| 5 | Rejected |
| 4 | Rejected |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
1. Please remove 48-50 from shell version. 2. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. `lookupByUUID()` is a bad practice (line 37 `extension.js`). You can send `this` from the entry point to the class needing it (dependency injection). 4. Add to the description that this extension is using `goldprice.org` services. 5. Change `_onDestroy()` (line 157 `extension.js`) to `destroy()`. Also change line 160 to `super.destroy()`. 6. Remove version from import (line 23 `extension.js`). Not needed. 7. Please don't store any instance of objects in a property in the default class you are exporting (line 11 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Make it local to `fillPreferencesWindow()` function or you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 8. Don't use spawn command for opening the prefs window (line 62 `extension.js`). You have `this.openPreferences()` in the entry point: [Port Guide 45: openPreferences](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils)
Gold Price Monitor