Review "Gold Price Monitor" version 5 - GNOME Shell Extensions

Review of "Gold Price Monitor" version 5

Details Page Preview

Gold Price Monitor

by QAnwcks5aTq6

A Gnome extension helps you tracking gold price in realtime. Service provider: goldprice.org

Extension Homepage: https://github.com/wotmshuaisi/goldpricemonitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
33	Active
32	Rejected
31	Rejected
30	Rejected
29	Rejected
28	Active
27	Active
26	Inactive
25	Inactive
24	Inactive
23	Inactive
22	Inactive
21	Inactive
20	Inactive
19	Inactive
18	Inactive
17	Rejected
16	Active
15	Inactive
14	Rejected
13	Inactive
12	Inactive
11	Inactive
10	Rejected
9	Active
8	Inactive
7	Rejected
6	Rejected
5	Rejected
4	Rejected
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

user_41190 posted a review August 16, 2019

andyholmes rejected September 4, 2019

Your extension looks mostly ok, however you create objects, connect signals and create mainloop sources in `init()`, as well as the top-level of your script, which is not permitted. Objects, signal handlers and mainloop sources must be created in `enable()` and destroyed in `disable()`. Please fix these issues so I can approve your extension. See: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review