GNOME Shell Extensions

Review of "Gold Price Monitor" version 38

Details Page Preview

Gold Price Monitor

by QAnwcks5aTq6

A Gnome extension helping you track gold price in realtime. Primary provider: goldprice.org, optional secondary: goldapi.io

Extension Homepage
https://github.com/wotmshuaisi/goldpricemonitor
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:211 
          this._settings.connect(`changed::${key}`, () => {
        this.disable();
        this.enable();
      })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:21 
    this._httpSession = new Soup.Session()

All Versions

Previous Reviews on this Version

fmuellner active