Review of "Grab Song" version 1

Details Page Preview

A GNOME Shell extension that displays your currently playing Spotify song in the top panel and allows you to download it with a single click using spotdl.

Extension Homepage
https://github.com/sxoxgxi/grabsong

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Don't use sync spawn since that can freeze the shell process (line 169 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 3. Timeout should be removed on disable (line 82 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. You should close the pid on disable (line 73 `extension.js`): [GLib.spawn_close_pid](https://gjs-docs.gnome.org/glib20~2.0/glib.spawn_close_pid) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions